ci: formatting and misc improvements #5802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This amends the following commits: * 370b9db ("gitlab pipeline fixes", 2020-04-21) * 42fdea7 ("gitlab", 2020-04-21) Added on commit 2e14c1a ("Adding sort.py to GitLab CI (netblue30#2973)", 2019-09-21).
This makes each workflow ignore every other workflow. Relates to netblue30#5481.
Kind of relates to commit 6d0c751 ("split make test-github into different actions", 2023-01-31).
For increased readability. Note: `>` basically turns each newline into a space while `|` keeps newlines as is. Both remove leading indentation. Note2: On jobs using `apt-get install`, this commit moves package names to their own line, to make it easier to compare which packages are being installed across such jobs.
To turn each step in question into a normal multi-line shell script. Note that each step already runs with `set -e` by default.
kmk3
force-pushed
the
ci-format-improve
branch
2 times, most recently
from
f6fa3b5 to
4861b79
Compare
Changes: * Add quotes around variables * Use single quotes where applicable
To make debugging easier.
To make debugging easier. Use a separate shell script instead of just a make target to ensure that it can safely run before ./configure and without having make installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits:
The changes are mostly about making the workflows easier to read and debug.
This is a follow-up to #5795.
Relates to #5481.