Skip to content

profiles: bleachbit: allow erasing Trash contents #5902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

profiles: bleachbit: allow erasing Trash contents #5902

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2023

I made a feature request that was liked a while back (#5337), and they suggested I make a pull request. It took me a long time to get around to it but here it is!

Explanation:
Bleachbit is used to permanently delete files by overwriting the memory. So the most popular feature of Bleachbit is emptying the Trash.

But bleachbit.profile includes disable-common.inc which blacklists ${HOME}/.local/share/Trash so it's not possible to empty the trash with Bleachbit.

These are the two lines i added:

# Necessary for BleachBit to erase Trash contents. 
noblacklist ${HOME}/.local/share/Trash

Bleachbit is used to permanently delete files by overwriting the memory.
So the most popular feature of Bleachbit is emptying the Trash.
@kmk3 kmk3 changed the title Necessary for BleachBit to erase Trash contents bleachbit.profile: allow erasing Trash contents Jul 15, 2023
@ghost ghost closed this by deleting the head repository Jul 15, 2023
@ghost
Copy link
Author

ghost commented Jul 15, 2023

Oh did i mess this up? I thought my fork isn't needed any more? This is like my second pull request in like 10+ years lol so not sure. let me know if I need to redo this

@rusty-snake
Copy link
Collaborator

rusty-snake commented Jul 15, 2023

The ref should still be there and can be merged(cherry-picked) by hand.

@kmk3
Copy link
Collaborator

kmk3 commented Jul 16, 2023

Oh did i mess this up? I thought my fork isn't needed any more? This is like
my second pull request in like 10+ years lol so not sure. let me know if I
need to redo this

The PR was fine; I just edited the commit message to make it closer to the
usual style.

Please avoid deleting the source branch/repository while a PR is ongoing, as
that prevents reopening the PR.

Anyway, I cherry-picked it to master as commit 154ffad ("bleachbit.profile:
allow erasing Trash contents", 2023-07-15).

It should be working fine now, thanks for the changes.

@kmk3 kmk3 changed the title bleachbit.profile: allow erasing Trash contents profiles: bleachbit: allow erasing Trash contents Sep 7, 2024
kmk3 added a commit that referenced this pull request Sep 28, 2024
@kmk3 kmk3 added the bugfix This fixes a bug label Dec 29, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This fixes a bug
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants