Skip to content

profiles: add allow-php.inc to profile.template #6299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

kmk3
Copy link
Collaborator

@kmk3 kmk3 commented Mar 30, 2024

To make it consistent with the other include profiles.

See etc/templates/profile.template.

Note: It is not currently included in any profile.

Added on commit 89f30f1 ("Create allow-php.inc", 2020-01-25).

This is a follow-up to #6298.

@kmk3 kmk3 requested a review from glitsj16 April 2, 2024 11:22
To make it consistent with the other include profiles.

See etc/templates/profile.template.

Note: It is not currently included in any profile.

Added on commit 89f30f1 ("Create allow-php.inc", 2020-01-25).

This is a follow-up to netblue30#6298.
@kmk3 kmk3 force-pushed the profiles-add-php-template branch from ea8a268 to 481ddbe Compare April 2, 2024 11:32
@kmk3 kmk3 changed the title profiles: add allow-php.inc to profiles.template profiles: add allow-php.inc to profile.template Apr 2, 2024
@kmk3 kmk3 merged commit e6b10a4 into netblue30:master Apr 3, 2024
3 checks passed
@kmk3 kmk3 deleted the profiles-add-php-template branch April 3, 2024 00:02
kmk3 added a commit to kmk3/firejail that referenced this pull request Apr 4, 2024
To make it consistent with the other include profiles.

See etc/templates/profile.template.

With this, all `etc/inc/allow-*` files are listed in profile.template.

The explanation is based on a comment by @rusty-snake[1].

Relates to netblue30#4071.

This is a follow-up to netblue30#6299.

[1] netblue30#4071 (comment)
kmk3 added a commit that referenced this pull request Apr 5, 2024
To make it consistent with the other include profiles.

See etc/templates/profile.template.

With this, all `etc/inc/allow-*` files are listed in profile.template.

The explanation is based on a comment by @rusty-snake[1].

Relates to #4071.

This is a follow-up to #6299.

[1] #4071 (comment)
kmk3 added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants