Skip to content

bugfix: fix various resource leaks #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

bugfix: fix various resource leaks #6367

merged 1 commit into from
Jun 5, 2024

Conversation

i-pankrat
Copy link
Contributor

@i-pankrat i-pankrat commented Jun 3, 2024 •
edited
Loading

Fix memory and descriptor leaks.

glitsj16
glitsj16 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@glitsj16 glitsj16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks for the patches!

@i-pankrat
Copy link
Contributor Author

Seems that there are some troubles. I'll double-check.

kmk3
kmk3 requested changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, with a few requested changes.

@i-pankrat i-pankrat changed the title Fix resource leaks and a typo Fix resource leaks Jun 4, 2024
@i-pankrat i-pankrat requested a review from kmk3 June 4, 2024 06:56
@kmk3 kmk3 changed the title Fix resource leaks bugfix: fix various resource leaks Jun 4, 2024
kmk3
kmk3 reviewed Jun 4, 2024
View reviewed changes
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please amend the commit message title to match the PR title so that it's
consistent with the RELNOTES.

Also, it would be nice to have the PR description in the commit itself as well:

bugfix: fix various resource leaks

Fix memory and descriptor leaks.

@i-pankrat
bugfix: fix various resource leaks
b581ab3 
Fix memory and descriptor leaks.

Signed-off-by: Ilya Pankratov <[email protected]>
@i-pankrat i-pankrat requested a review from kmk3 June 5, 2024 05:16
kmk3
kmk3 approved these changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@kmk3 kmk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done; thanks for the many fixes!

@kmk3 kmk3 merged commit 03ea436 into netblue30:master Jun 5, 2024
13 checks passed
kmk3 added a commit that referenced this pull request Jun 10, 2024
@kmk3
RELNOTES: add many items
42bdb78 
Relates to #6352 #6353 #6354 #6358 #6359 #6361 #6366 #6367 #6369.
@kmk3 kmk3 added the bugfix This fixes a bug label Dec 29, 2024
@kmk3 kmk3 mentioned this pull request Jan 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glitsj16 glitsj16 glitsj16 approved these changes

@kmk3 kmk3 kmk3 approved these changes

Assignees
No one assigned
Labels
bugfix This fixes a bug
Projects
Release 0.9.74
Status: Done (on RELNOTES)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@i-pankrat @glitsj16 @kmk3