-
Notifications
You must be signed in to change notification settings - Fork 595
profiles: floorp: add profile sync daemon paths #6683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I see; I noticed that GitHub shows literal
I can fix it later, but how did you create the commit? |
I made the commit from the terminal, but I'm not familiar with Git yet. |
I assume that this is due to trying to write a multiline commit message using Using that command is best avoided in general (other than in scripts); it's There are also many extraneous commits now. You can squash/fixup the commits: Then amend the resulting commit: git commit --amend And edit the message to fix the newlines, for example:
In this case the change is simple and obvious enough that a single line is See the following guide later, as it has some good advice for improving commit Also, instead of creating new commits, you can keep editing the same one and # (Do some changes)
git add -u
git commit --amend
git push --force-with-lease Also:
Please avoid merging from/rebasing to master unless there is a good reason, as And if you are going to do it, I'd use rebase instead of merge, as the end git checkout mybranch
git rebase master |
Also, fix a typo.
b81f12e
to
8969b20
Compare
This is used by at least floorp and FirefoxPWA. This is a follow-up to netblue30#6683.
This is used by at least floorp and FirefoxPWA. This is a follow-up to #6683.
Fix typo.
Denying read-write access to ${HOME}/.local/share/applications prevents Floorp from creating shortcuts to the application launcher, which breaks the (experimental) PWA feature on Linux.
Additionally i whitelisted the directories
${RUNUSER}/*floorp*
andwhitelist
${RUNUSER}/psd/*floorp*
to enable profile-sync-daemon support.Since this is my first time doing a PR, I may have missed something, feel free to edit if needed.
Relates to: