Skip to content

profiles: floorp: add profile sync daemon paths #6683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2025

Conversation

Renkoto
Copy link
Contributor

@Renkoto Renkoto commented Mar 16, 2025

Fix typo.

Denying read-write access to ${HOME}/.local/share/applications prevents Floorp from creating shortcuts to the application launcher, which breaks the (experimental) PWA feature on Linux.

Additionally i whitelisted the directories ${RUNUSER}/*floorp* and
whitelist ${RUNUSER}/psd/*floorp* to enable profile-sync-daemon support.

Since this is my first time doing a PR, I may have missed something, feel free to edit if needed.

Relates to:

@github-project-automation github-project-automation bot moved this to In progress in Release 0.9.74 Mar 22, 2025
@kmk3
Copy link
Collaborator

kmk3 commented Mar 22, 2025

Since this is my first time doing a PR, I may have missed something, feel
free to edit if needed.

I see; I noticed that GitHub shows literal \n characters (not newlines) in
the commit message:

Update floorp.profile for PWA and PSD support\n\n- Added  to fix PWA .desktop file creation blocked by disable-common.inc\n- Added whitelists and noblacklists for Profile Sync Daemon compatibility with Floorp profile dirs

I can fix it later, but how did you create the commit?

@Renkoto
Copy link
Contributor Author

Renkoto commented Mar 23, 2025

Since this is my first time doing a PR, I may have missed something, feel
free to edit if needed.

I see; I noticed that GitHub shows literal \n characters (not newlines) in the commit message:

Update floorp.profile for PWA and PSD support\n\n- Added  to fix PWA .desktop file creation blocked by disable-common.inc\n- Added whitelists and noblacklists for Profile Sync Daemon compatibility with Floorp profile dirs

I can fix it later, but how did you create the commit?

I made the commit from the terminal, but I'm not familiar with Git yet.

@kmk3
Copy link
Collaborator

kmk3 commented Mar 23, 2025

I can fix it later, but how did you create the commit?

I made the commit from the terminal, but I'm not familiar with Git yet.

I assume that this is due to trying to write a multiline commit message using
git commit -m.

Using that command is best avoided in general (other than in scripts); it's
better to just use git commit and write the commit message in your text
editor of choice (which can be set with the EDITOR environment variable).


There are also many extraneous commits now.

You can squash/fixup the commits:

Then amend the resulting commit:

git commit --amend

And edit the message to fix the newlines, for example:

profiles: floorp: add profile sync daemon paths

In this case the change is simple and obvious enough that a single line is
fine.

See the following guide later, as it has some good advice for improving commit
messages:

Also, instead of creating new commits, you can keep editing the same one and
force-pushing it. Example:

# (Do some changes)
git add -u
git commit --amend
git push --force-with-lease

Also:

  • Merge branch 'floorp-profile-pwa-fix', remote-tracking branch 'origin'

Please avoid merging from/rebasing to master unless there is a good reason, as
it makes review harder (and adds noise to the branch when merging).

And if you are going to do it, I'd use rebase instead of merge, as the end
result is contains less noise (that is, no merge commit). Example:

git checkout mybranch
git rebase master

@Renkoto Renkoto requested a review from kmk3 March 23, 2025 16:03
@kmk3 kmk3 force-pushed the floorp-profile-pwa-fix branch from b81f12e to 8969b20 Compare March 23, 2025 17:04
@kmk3 kmk3 changed the title profiles: floorp: Fix PWAs and profile-sync daemon profiles: floorp: add profile sync daemon paths Mar 23, 2025
@kmk3 kmk3 merged commit 5ec6567 into netblue30:master Mar 23, 2025
3 checks passed
@Renkoto Renkoto deleted the floorp-profile-pwa-fix branch March 23, 2025 17:11
kmk3 added a commit that referenced this pull request Mar 23, 2025
@kmk3 kmk3 moved this from In progress to Done (on RELNOTES) in Release 0.9.74 Mar 23, 2025
kmk3 added a commit that referenced this pull request Mar 23, 2025
This amends commit 5ec6567 ("profiles: floorp: add profile sync daemon
paths (#6683)", 2025-03-23).
kmk3 added a commit that referenced this pull request Mar 24, 2025
This amends commit dd0f76c ("RELNOTES: add profile item", 2025-03-23).

Relates to #6030 #6683.
kmk3 pushed a commit to Renkoto/firejail that referenced this pull request Mar 30, 2025
This is used by at least floorp and FirefoxPWA.

This is a follow-up to netblue30#6683.
kmk3 pushed a commit that referenced this pull request Mar 30, 2025
This is used by at least floorp and FirefoxPWA.

This is a follow-up to #6683.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done (on RELNOTES)
Development

Successfully merging this pull request may close these issues.

2 participants