Skip to content

fix: Encoding plus symbol in URI's #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 26, 2024
Merged

fix: Encoding plus symbol in URI's #191

merged 2 commits into from
Dec 26, 2024

Conversation

cbaker6
Copy link
Member

@cbaker6 cbaker6 commented Dec 26, 2024

New Pull Request Checklist

Issue Description

Close #189

Approach

Encode all plus values in query parameters.

TODOs before merging

  • Add tests
  • Add entry to changelog
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (0d51e70) to head (39f261a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #191   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files         179      179           
  Lines       15919    15934   +15     
=======================================
+ Hits        14617    14632   +15     
  Misses       1302     1302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbaker6 cbaker6 merged commit 278d971 into main Dec 26, 2024
14 checks passed
@cbaker6 cbaker6 deleted the fixEncodingURL branch December 26, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while query users with emails that contains +(plus) character
1 participant