-
Notifications
You must be signed in to change notification settings - Fork 24
codegen web generate handler only returns zip file name and not content #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
My original thought was to generate the file and put it into /tmp/zip and then return the filename to the caller. If we have a single page application that renders the UI, it can display the link on the browser to allow user to download. Returning zip file directly will work but I guess the end user must choose a filename to save locally. I think both approach should work and we just need to pick up one that is easier. What do you think? Do you want to try it to return zip file content? Thanks. |
@stevehu I can take a look at this if no one has already? |
@NicholasAzar Yes. Please do. Thanks. |
hi @NicholasAzar , was wondering if the issue was fixed?
wanted to confirm if it was fixed and if possible would you might know why i might not be getting a response. |
@auahmed yeah it was working for me when i finished. I think you just need to make sure what you have installed is the latest from develop. Double check to see if your local light, light-hybrid, and light-codegen (in that order) are both on develop with latest pulled, and installed. If that doesn't solve the problem i'll spend more time trying to recreate the issue. |
Thanks @NicholasAzar !!! i guess i hadn't built it in the right order and cuz of that it did not work before. |
@NicholasAzar was there a specific reason you switched from using axios to form for the download button? |
@auahmed it was only since I already knew file download from a form and didn't want to risk going down a rabbit hole 😄 |
This is released along with version 1.5.11 |
If the handler is used as a service and hosted somewhere for people to visit and access via a website, the request should return the actual zip file itself rather then the file name as the user might not have access to the server.
Currently the file is placed into /tmp/zip looking at the default config directory settings.
The text was updated successfully, but these errors were encountered: