Skip to content

feat(zip): Adding handler to return a zip object to the client. #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2018

Conversation

DSchrupert
Copy link
Member

@DSchrupert DSchrupert commented Mar 18, 2018

Since we don't pass the exchange to the handler to populate response headers.. i needed to add a new one to ensure the right content type & dispositions are used.

Let me know if there's anything i should change.

In regards to: networknt/light-codegen#112

Thanks

@DSchrupert DSchrupert requested a review from stevehu March 18, 2018 01:36
@DSchrupert
Copy link
Member Author

@stevehu what i also noticed in this approach (of not having the handlers responsible for the response headers) is that they can no longer return errors to the client if the RpcRouter is always expecting a file...
I think we might want to reconsider the handler interface parameters.
Thoughts? Am i missing something?

@stevehu
Copy link
Contributor

stevehu commented Mar 18, 2018

You are absolutely right. We should pass the exchange to handlers so that they can set headers or respond errors based on business logic. Since the entire portal and most of networknt services are depending on it. Let's think through it and make all changes in one shot. Let me come up an impl in a branch and we can chat about the pros and cons. Or you can take an initiative if you have time. My entire next week is planned already and I need a big chunk of time to do this.

@stevehu stevehu merged commit 1db965c into develop Mar 18, 2018
@DSchrupert DSchrupert deleted the feature/zip_resp_handler branch March 18, 2018 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants