drivers/main.c: move "-d" CLI option handling also to start of program #2408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Klimov <[email protected]>
…m [fallout of networkupstools#2259] We consult the value of `dump_data` to decide about foreground mode, but after moving the `-D` option handling (and this decision) upwards to facilitate early debugging, the variable is never modified in time anymore. Thanks for the catch to Eric Clappier and IPM/42ity team. Signed-off-by: Jim Klimov <[email protected]>
jimklimov
added
bug
service/daemon start/stop
FrancoisRegisDegott-eaton
approved these changes
Apr 17, 2024
ericclappier-eaton
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallout of #2259 / PR #2260 (regression in NUT v2.8.2 release, not a default code path and can be worked around with explicit
-F/-BCLI options, though - so not extremely critical)Thanks to @ericclappier-eaton @arnaudquette-eaton @FrancoisRegisDegott-eaton and 42ITy team.