Ve-direct driver #440
Ve-direct driver #440
Conversation
|
Sorry for failed CI, fixed now. |
| } | ||
|
|
||
| void upsdrv_shutdown(void) | ||
| { |
There was a problem hiding this comment.
Is there certainly no session teardown?
|
|
||
| /* list flags and values that you want to receive via -x */ | ||
| void upsdrv_makevartable(void) | ||
| { |
There was a problem hiding this comment.
Aren't there variables to set up or modify like the port, maybe baud speed (e.g. use a default 19200 but reserve ability to probe related units with other hardware abilities)?
|
I would prefer that these commits be rebased/squashed rather than merged as-is. The individual commits do not stand on their own. https://github.com/networkupstools/nut/blob/master/docs/developers.txt#L327 |
drivers/ve-direct.c
Outdated
| break; | ||
| *end = '\0'; | ||
|
|
||
| snprintf(vn, sizeof(vn), "ve-direct.%s", v_name); |
There was a problem hiding this comment.
"ve-direct" is not a valid top-level NUT variable name. Please use the standard names defined, and discuss on nut-upsdev if you need anything not covered here: http://networkupstools.org/docs/developer-guide.chunked/apas01.html
There was a problem hiding this comment.
"Fixed" by moving to experimental.* namespace. Generally we would need a PV-oriented namespace, I suppose (#1407 also stumbles on that).
|
|
||
| void upsdrv_initups(void) | ||
| { | ||
| #ifndef TESTING |
There was a problem hiding this comment.
The TESTING #define is not handled elsewhere in NUT, but if you include it, I would recommend adding a case to parse a few static text buffers. This will help other developers who might have to maintain the code later down the road.
There was a problem hiding this comment.
There's actually a lot of it in blazer and nutdrv_qx code... Still not really handled in a centralized fashion, but as a precedent - there certainly is some.
… we check for third-party dependencies
…and consult drivers/Makefile.am for list names to require certain dependencies
…sx) drivers - do not default to require them everywhere
…platform-dependent package groups
|
Resyncing with main NUT code base after v2.8.3 release. |
networkupstools#440] Signed-off-by: Jim Klimov <[email protected]>
Suggestion to RTFM is now centralized in NUT code base Signed-off-by: Jim Klimov <[email protected]>
|
✅ Build nut 2.8.3.3053-master completed (commit 30fc0568c1 by @jimklimov) |
Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…ls#440] Signed-off-by: Jim Klimov <[email protected]>
|
TODO: Man page and similar docs... UPDATE: Done |
…ls monitoring [networkupstools#440] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
…ix a few typos [networkupstools#440] Signed-off-by: Jim Klimov <[email protected]>
Signed-off-by: Jim Klimov <[email protected]>
|
Well, there are a few rough edges remaining, but I think the PR became good enough to merge (and then maybe chisel to perfection as part of common NUT code base - e.g. document the parameters which the INSTCMD can get/set). Thanks @pkubanek ! |
Working release of Ve-direct driver for Victron Energy UPS/solar panels monitoring.