This repository was archived by the owner on Jun 3, 2025. It is now read-only.
[fix] match metric names ignoring separators #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
approved these changes
May 8, 2023
dbogunowicz
approved these changes
May 8, 2023
bfineran
added a commit
that referenced
this pull request
May 8, 2023
bfineran
added a commit
that referenced
this pull request
May 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after this change, metric names like
top1accuracyandTop 1 Accuracywill matchadditionally fixes minor bug where metric names were evaluated incorrectly when not contained in a list
test_plan:
fixes broken existing unit tests