This repository was archived by the owner on Jun 3, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Enable the easy download of the deployment.tar.gz #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbogunowicz
commented
Oct 25, 2023
dbogunowicz
commented
Oct 25, 2023
dbogunowicz
commented
Oct 25, 2023
e49483f
to
3139080
Compare
bfineran
reviewed
Oct 25, 2023
dbogunowicz
commented
Oct 26, 2023
dbogunowicz
commented
Oct 26, 2023
dbogunowicz
commented
Oct 26, 2023
bfineran
previously approved these changes
Nov 2, 2023
rahul-tuli
previously approved these changes
Nov 2, 2023
bfineran
approved these changes
Nov 6, 2023
bfineran
approved these changes
Nov 14, 2023
dbogunowicz
added a commit
that referenced
this pull request
Nov 15, 2023
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
bfineran
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting to the state of #375 in order to enable, in the simplest way possible, the fetching of only
deployment.tar.gz
.The crux of this PR is adding
self.deployment_tar
attribute to theModel
and allowing it to be correctly initialized not only from the stub but also from the local directory.Added unit tests that test this feature.
Manual tests:
out: