fix call to alloca in a loop php_api_datastore #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newrelic-php-agent/agent/php_api_datastore.c
Lines 57 to 60 in 765888d
fixed
php_api_datastore
call to alloca in a loop, replace the use ofnr_alloca
withmalloc
to allocate memory on the heap. This ensures that memory is properly freed after each iteration, avoiding stack overflow risks. Specifically:nr_alloca(sizeof(datastore_validators[i].default_value))
withmalloc(sizeof(datastore_validators[i].default_value))
.free(default_value)
after the memory is used in each iteration to prevent memory leaks.References