fix: Fixed error reporting from async Fastify handlers #3100
Conversation
There was a problem hiding this comment.
This is the original errors.test.js file. I moved it to this file because it seems to be testing errors from the Express compatibility modules (though, I'm not completely convinced of that).
| await promise | ||
| }) | ||
|
|
||
| test('asynchronous handler errors', async (t) => { |
There was a problem hiding this comment.
This test fails without the promise: true lines added in the instrumentation.
jsumners-nr
force-pushed
the
fastify-error-fix
branch
from
087f8f1 to
d8fc5ef
Compare
github-project-automation
bot
moved this from Needs PR Review
to Done: Issues recently completed
in Node.js Engineering Board
|
For those following along: the "fix" in this PR is updating the instrumentation to indicate that the request handlers are possibly promises. But that fix has caused unexpected, difficult, changes that we are working to resolve. |
kmudduluru
moved this from Done: Issues recently completed
to Triage Needed: Unprioritized Features
in Node.js Engineering Board
|
Thanks for the update. I’m currently running into this issue as well—do you have an estimated timeline for when a fix might be in place? @jsumners-nr |
|
We had to backlog this for a bit to work on a higher priority item. We'll be picking this one back up shortly. No current ETA, but hopefully soon. |
kmudduluru
moved this from Triage Needed: Unprioritized Features
to Reviewed
in Node.js Engineering Board
This PR resolves #3099.