fix(adapter): transistion to surrealdb@^1.0.0 #11911
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
@dvanmali is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
added
adapters
dvanmali
changed the title
dvanmali
changed the title
…exponential backoff for disconnection events to example
|
Any updates on this PR? Would love to see it merged so we can use SurrealDB with Auth.js! |
|
Is this PR still up-to-date ? Looking forward to use SurrealDB and AuthJS together but with surrealdb v2 it doesnt work anymore. |
Yes this PR should still work with v2, if you have issues let me know |
|
@dvanmali sorry for my bad english, i ment whether this PR will ever get merged :D I just copied your index.ts file and imported from local package, works perfectly fine. Thanks🫱🏼🫲🏽 |
|
Hi @ThangHuuVu ! 👋 Hope you are doing well! Could you please help give a review and ship this PR? This has been blocking for SurrealDB and Auth.js users for a while. Thank you in advance! |
|
@ThangHuuVu Since this is a blocking PR, can we get this reviewed and merged ASAP please? |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
There was a problem hiding this comment.
Thanks for putting this together! the tests are passing on my end, but during testing I need to use the v1.5 tag for the docker image, as the latest tag gives me this error:
UnsupportedVersion: The version "1.0.0+20230913.54aedcd" reported by the engine is not supported by this library, expected a version that satisfies ">= 1.4.2 < 3.0.0".
Lets see if the CI test passes
|
@dvanmali the lockfile needs to be updated, could u help with that? You are creating the PR from your |
|
Sure @ThangHuuVu, just updated the lockfile and fixed the shell script so it can now pass your test scripts. It appears that Surrealdb v3-alpha is currently tied to latest so it may not currently be compatible as they mention on their javascript library. |
|
Feel free to message this thread again if you wish for another update or add a PR or issue to my main. Unfortunately because I don't have write access to this repo, i can't make a branch here, hence the forked repo from main |
|
Were you able to take a look @ThangHuuVu? |
☕️ Reasoning
Moves package dependency to version 1 of the surrealdb javascript library. Package includes websocket connectivity, type safety, updates to the setup documentation, and package peer dependency change.
🧢 Checklist
🎫 Affected issues
#11732 - solves this by transistioning to [email protected] package. Docs state to use new connection string.
#11866 - javascript package supports surrealdb v2
#11471 - uses current surrealdb software
📌 Resources