-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
fix: always check typeof BroadcastChannel #12937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@maiconcarraro is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
The build is failing, could you ensure it pass before merging @maiconcarraro |
@ThangHuuVu the pnpm scripts seems to be unfriendly to windows OS, so its a little bit harder to reproduce... but I addressed the Broadcast error from GH pipeline and all the null references were gone after it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12937 +/- ##
==========================================
- Coverage 39.19% 39.18% -0.01%
==========================================
Files 200 200
Lines 31606 31612 +6
Branches 1374 1380 +6
==========================================
Hits 12388 12388
- Misses 19218 19224 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
☕️ Reasoning
This PR #11470 fixed one issue, but bypassed the check for
typeof BroadcastChannel
which causes issue for Safari 15.3 or lower. See: #12936🧢 Checklist
🎫 Affected issues
Fixes: #12936
📌 Resources