Skip to content

fix: always check typeof BroadcastChannel #12937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025

Conversation

maiconcarraro
Copy link
Contributor

@maiconcarraro maiconcarraro commented May 4, 2025

☕️ Reasoning

This PR #11470 fixed one issue, but bypassed the check for typeof BroadcastChannel which causes issue for Safari 15.3 or lower. See: #12936

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Fixes: #12936

📌 Resources

@maiconcarraro maiconcarraro requested a review from ThangHuuVu as a code owner May 4, 2025 16:47
Copy link

vercel bot commented May 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2025 1:34am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview May 13, 2025 1:34am

Copy link

vercel bot commented May 4, 2025

@maiconcarraro is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@ThangHuuVu
Copy link
Member

The build is failing, could you ensure it pass before merging @maiconcarraro

@maiconcarraro
Copy link
Contributor Author

@ThangHuuVu the pnpm scripts seems to be unfriendly to windows OS, so its a little bit harder to reproduce... but I addressed the Broadcast error from GH pipeline and all the null references were gone after it.

image

@ThangHuuVu ThangHuuVu merged commit f39867a into nextauthjs:main May 13, 2025
10 of 12 checks passed
Copy link

codecov bot commented May 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 39.18%. Comparing base (baa15f4) to head (2e5ae58).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/next-auth/src/react.tsx 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12937      +/-   ##
==========================================
- Coverage   39.19%   39.18%   -0.01%     
==========================================
  Files         200      200              
  Lines       31606    31612       +6     
  Branches     1374     1380       +6     
==========================================
  Hits        12388    12388              
- Misses      19218    19224       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: Can't find variable: BroadcastChannel
2 participants