-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Fix undefined providerId #12947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix undefined providerId #12947
Conversation
Client-side auth with no `providerId` param results in error.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
@Regloom is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
thanks for the fix, could you add a test for it? |
Ok, tests added. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12947 +/- ##
=======================================
Coverage ? 39.19%
=======================================
Files ? 200
Lines ? 31615
Branches ? 1382
=======================================
Hits ? 12391
Misses ? 19224
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
☕️ Reasoning
Client-side auth with no
providerId
param results in error. Sample code:It's caused by parseActionAndProviderId function which returns providerId = "undefined" (as a string). This breaks the following check auth/core/src/lib/utils/providers.ts
🧢 Checklist
🎫 Affected issues
📌 Resources