fix(documentation): do not remove JSDoc types in Vue JS files #995
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.vue
when there it has nolang="ts"
#980npm run lint
breaks many Vue + JS files if TS config is usedHalf-working solution
jsdoc/require-property-type
makes no harm in TS, there are no@property
.vue
files (that can be both TS and JS):jsdoc/no-types
only if there are TS typesjsdoc/require-param-type
only if there are no TS typesjsdoc/require-returns-type
(because a return type is often inferred, not specified)jsdoc/check-tag-names
(because it can be used in a JS component)So it doesn't break existing JS components (like before).
But it applies only ~half of JSDoc + TS rules in TS components.
Alternative
Generate
files
on the fly by checking<script lang>
to distinguish between JS and TS Vue files.