Skip to content

[next] fix(NcInputField): Make sure label and placeholder is not jumping #5832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Jul 18, 2024

Backport of #5821

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews feature: input-field Covering the InputField, TextField, ... labels Jul 18, 2024
@raimund-schluessler raimund-schluessler added this to the 9.0.0-alpha.6 milestone Aug 5, 2024
Rework layout logic to ensure the label is not jumping on focus.
This was caused as our border width changes when focusing.

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the backport/5821/next branch from 82f20d7 to e19695b Compare January 19, 2025 13:35
@susnux susnux marked this pull request as ready for review January 19, 2025 13:37
Co-authored-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit 2da1fef into next Jan 19, 2025
20 checks passed
@susnux susnux deleted the backport/5821/next branch January 19, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: input-field Covering the InputField, TextField, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants