Skip to content

refactor: Migrate NcButton from render function to template #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

refactor: Migrate NcButton from render function to template #6033

merged 1 commit into from
Apr 16, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 30, 2024 •
edited
Loading

☑️ Resolves

  1. Make it a template component instead of a render function
  2. Add a text prop to allow passing text content as prop
  3. Add noIconAriaHidden to allow making the icon appear on the accessible tree

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@susnux susnux mentioned this pull request Aug 30, 2024
Open
@susnux susnux force-pushed the feat/refactor-nc-button branch from e8fd644 to 1b5c7b5 Compare August 30, 2024 19:03
@susnux susnux mentioned this pull request Jan 18, 2025
Merged
15 tasks
@susnux susnux force-pushed the feat/refactor-nc-button branch 2 times, most recently from ab9aed0 to 04e0282 Compare January 19, 2025 16:08
@susnux susnux added 3. to review Waiting for reviews feature: button vue 3 Related to the vue 3 migration feature: functions composables, functions, mixins and other non-components refactor ♻️ Pull request that is neither a fix nor a feature labels Jan 19, 2025
@susnux susnux modified the milestones: 9.0.0-alpha.6, 8.23.0, 9.0.0 Jan 19, 2025
@susnux susnux changed the title feat: Refactor NcButton refactor: Migrate NcButton from render function to template Jan 19, 2025
@susnux susnux removed the feature: functions composables, functions, mixins and other non-components label Jan 19, 2025
@susnux susnux force-pushed the feat/refactor-nc-button branch from 04e0282 to c0dd0de Compare January 19, 2025 18:10
@susnux susnux marked this pull request as ready for review January 19, 2025 18:14
ShGKme
ShGKme reviewed Jan 21, 2025
View reviewed changes
@susnux susnux force-pushed the feat/refactor-nc-button branch from 541f542 to 228fb39 Compare January 22, 2025 11:12
@susnux susnux force-pushed the feat/refactor-nc-button branch from 228fb39 to 562a8b7 Compare January 29, 2025 11:20
ShGKme
ShGKme reviewed Jan 29, 2025
View reviewed changes
@susnux susnux mentioned this pull request Feb 16, 2025
Merged
13 tasks
@susnux susnux force-pushed the feat/refactor-nc-button branch from 8c2283e to f9979b9 Compare February 28, 2025 22:34
@susnux susnux requested a review from ShGKme February 28, 2025 22:35
@susnux susnux mentioned this pull request Mar 1, 2025
Merged
3 tasks
@susnux susnux force-pushed the feat/refactor-nc-button branch from f9979b9 to 17607b3 Compare April 1, 2025 17:40
@susnux susnux requested a review from Antreesy April 1, 2025 17:41
@ShGKme
Copy link
Contributor

ShGKme commented Apr 1, 2025

With a force push instead of a fixup! it's hard to check what was changed since the last review, requiring a complete review again 👀

@susnux susnux force-pushed the feat/refactor-nc-button branch from 17607b3 to 82afb37 Compare April 1, 2025 19:47
@susnux
Copy link
Contributor Author

susnux commented Apr 1, 2025

With a force push instead of a fixup! it's hard to check what was changed since the last review, requiring a complete review again 👀

Sorry 🙈
Mostly only rebased.

Nevertheless this PR needs this backport first: #6595

@susnux susnux force-pushed the feat/refactor-nc-button branch from db74553 to 049b475 Compare April 2, 2025 11:05
@susnux
Copy link
Contributor Author

susnux commented Apr 2, 2025

Rebased to fix merge conflicts - no code changes.

@susnux susnux modified the milestones: 9.0.0, v9.0.0-rc.0 Apr 4, 2025
st3iny
st3iny reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nitpicks at your discretion. Looks fine overall.

@susnux @ShGKme
feat: Refactor NcButton
2c92c40 
1. Make it a template component instead of a render function
2. Add a `text` prop to allow passing text content as prop
3. Add `noIconAriaHidden` to allow making the icon appear on the accessible tree

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the feat/refactor-nc-button branch from ce03cb3 to 2c92c40 Compare April 16, 2025 08:44
@susnux susnux merged commit d189a7a into main Apr 16, 2025
30 checks passed
@susnux susnux deleted the feat/refactor-nc-button branch April 16, 2025 08:49
@susnux susnux mentioned this pull request Apr 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@st3iny st3iny st3iny approved these changes

@raimund-schluessler raimund-schluessler Awaiting requested review from raimund-schluessler

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: button refactor ♻️ Pull request that is neither a fix nor a feature vue 3 Related to the vue 3 migration
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @ShGKme @st3iny