[next] refactor(utils): Replace GenRandomId with getRandomId
#6425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
susnux
commented
Jan 23, 2025
susnux
commented
Jan 23, 2025
susnux
force-pushed
the
chore/refactor-getrandomid
branch
from
8c8a1c6 to
a64d43a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
chore/refactor-getrandomid
branch
from
068c557 to
9d885b8
Compare
This comment was marked as outdated.
This comment was marked as outdated.
ShGKme
reviewed
Jan 24, 2025
This comment was marked as resolved.
This comment was marked as resolved.
susnux
force-pushed
the
chore/refactor-getrandomid
branch
2 times, most recently
from
d52226f to
9f4a107
Compare
|
Adjusted @Antreesy should be good now. |
|
CI wouldn't agree with you 😆 I changed NcDateTimePickerNative inbetween, and someone else touched NavigationSettings: |
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
reviewed
Feb 28, 2025
susnux
force-pushed
the
chore/refactor-getrandomid
branch
from
9f4a107 to
c5f6f21
Compare
ShGKme
reviewed
Mar 3, 2025
ShGKme
reviewed
Mar 3, 2025
ShGKme
approved these changes
Mar 3, 2025
susnux
force-pushed
the
chore/refactor-getrandomid
branch
from
6e2d4eb to
52dae93
Compare
- Use Typescript for correct type annotations - Fix length problem (the old implemenation sometimes did not yield the expected length, e.g. if a "short" random number was generated)¹ - Add unit test for the util ¹ Did some benchmarks: Just the method is now ~10% slower. But the old method delivered too short values for ~25% of all cases. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
chore/refactor-getrandomid
branch
from
f6cdd97 to
38f9254
Compare
|
Backport to master? |
ShGKme
changed the title
GenRandomId with getRandomIdGenRandomId with getRandomId
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
¹ Did some benchmarks: Just the method is now ~10% slower. But the old method delivered too short values for ~25% of all cases.
🏁 Checklist
nextrequested with a Vue 3 upgrade