Skip to content

fix(NcAppSidebar, NcHeaderMenu): correctly focus trigger/close buggon when no focusable elements inside #6636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(NcAppSidebar, NcHeaderMenu): correctly focus trigger/close buggon when no focusable elements inside #6636

merged 1 commit into from
Mar 21, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Mar 21, 2025 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image -

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: header-menu labels Mar 21, 2025
@Antreesy Antreesy added this to the 8.24.0 milestone Mar 21, 2025
@Antreesy Antreesy requested review from susnux and ShGKme March 21, 2025 14:06
@Antreesy Antreesy self-assigned this Mar 21, 2025
susnux

This comment was marked as resolved.

Sign in to view

@Antreesy Antreesy added enhancement New feature or request and removed bug Something isn't working labels Mar 21, 2025
@Antreesy Antreesy changed the title fix(NcHeaderMenu): allow to disable focus-trap feat(NcHeaderMenu): allow to disable focus-trap Mar 21, 2025
@Antreesy Antreesy force-pushed the fix/noid/header-menu-focus-trap branch from bc45491 to 7c5b4b1 Compare March 21, 2025 16:14
@Antreesy Antreesy changed the title feat(NcHeaderMenu): allow to disable focus-trap fix(focus-trap): provide HTMLElement as fallbackFocus Mar 21, 2025
@Antreesy Antreesy requested a review from susnux March 21, 2025 16:16
@Antreesy
Copy link
Contributor Author

Let's start over, I should have used debugger in the first place

@Antreesy Antreesy added bug Something isn't working and removed enhancement New feature or request labels Mar 21, 2025
@Antreesy Antreesy requested a review from ShGKme March 21, 2025 16:17
@susnux susnux merged commit 2db8dbd into master Mar 21, 2025
23 checks passed
@susnux susnux deleted the fix/noid/header-menu-focus-trap branch March 21, 2025 16:57
@Antreesy
Copy link
Contributor Author

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 21, 2025
Merged
2 tasks
@ShGKme ShGKme changed the title fix(focus-trap): provide HTMLElement as fallbackFocus fix(NcAppSidebar, NcHeaderMenu): correctly focus trigger/close buggon when no focusable elements inside Mar 28, 2025
@ShGKme ShGKme mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug Something isn't working feature: header-menu
Projects
None yet
Milestone
8.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @susnux @ShGKme