Skip to content

fix(NcEmojiPicker): return focus steals actual focus #6652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2025
Merged

fix(NcEmojiPicker): return focus steals actual focus #6652

merged 1 commit into from
Mar 27, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Mar 27, 2025 •
edited by susnux
Loading

☑️ Resolves

Like in a focus-trap, we should only return focus on close if the closing action didn't add the focus already, for example, when the emoji picker was closed by clicking on an input field.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@ShGKme ShGKme added 3. to review Waiting for reviews regression Regression of a previous working feature feature: emoji picker Related to the emoji picker component labels Mar 27, 2025
@ShGKme ShGKme added this to the 8.24.0 milestone Mar 27, 2025
@ShGKme ShGKme requested review from DorraJaouad and Antreesy March 27, 2025 17:16
@ShGKme ShGKme self-assigned this Mar 27, 2025
Antreesy
Antreesy approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

DorraJaouad
DorraJaouad approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw it working

@ShGKme ShGKme merged commit ceead85 into master Mar 27, 2025
24 of 26 checks passed
@ShGKme ShGKme deleted the fix/NcEmojiPicker--return-focus-when-on-focusable branch March 27, 2025 19:55
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 27, 2025

/backport to next

@backportbot backportbot bot mentioned this pull request Mar 27, 2025
Merged
2 tasks
@ShGKme ShGKme added the bug Something isn't working label Mar 28, 2025
@ShGKme ShGKme mentioned this pull request Mar 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews bug Something isn't working feature: emoji picker Related to the emoji picker component regression Regression of a previous working feature
Projects
None yet
Milestone
8.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @DorraJaouad @Antreesy