Skip to content

refactor(NcActions): use provide/inject instead of $parent search #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 3, 2025
Merged

refactor(NcActions): use provide/inject instead of $parent search #6705

merged 2 commits into from
Apr 3, 2025

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 2, 2025

☑️ Resolves

  • getParent uses "hacky" solution searching for a parent via $parent in a loop
  • It is only used for NcActions to close the menu
  • Instead, explicitly provide an interface for closing the menu
  • Also, use typed injection keys

@susnux, sorry, this test didn't last long 🙇

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@ShGKme ShGKme added 3. to review Waiting for reviews feature: actions Related to the actions components refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 2, 2025
@ShGKme ShGKme requested review from susnux and Antreesy April 2, 2025 21:08
@ShGKme ShGKme self-assigned this Apr 2, 2025
susnux
susnux approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@ShGKme ShGKme requested a review from skjnldsv April 3, 2025 12:50
skjnldsv
skjnldsv approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop it you wizard! 🧙 😁

@skjnldsv skjnldsv merged commit 4858de7 into main Apr 3, 2025
24 checks passed
@skjnldsv skjnldsv deleted the chore/remove-getParent branch April 3, 2025 13:44
@susnux susnux mentioned this pull request Apr 3, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews feature: actions Related to the actions components refactor ♻️ Pull request that is neither a fix nor a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShGKme @susnux @skjnldsv