refactor!(NcModal): adjust to boolean props with default false
#6719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lse` Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
|
/backport 7bd9eec to stable8 |
ShGKme
approved these changes
Apr 4, 2025
Comment on lines
+88
to
+96
| | Component | Removed deprecated prop | New alternative | | ||
| |---------------|-------------------------|----------------------| | ||
| |`NcAppContent` | `allowSwipeNavigation` | `disabledSwipe` | | ||
| | `NcAvatar` | `showUserStatus` | `hideStatus` | | ||
| | `NcAvatar` | `showUserStatusCompact` | `verboseStatus` | | ||
| | `NcModal` | `closeButtonContained` | `closeButtonOutside` | | ||
| | `NcModal` | `enableSwipe` | `disableSwipe` | | ||
| | `NcModal` | `canClose` | `noClose` | | ||
| | `NcDialog` | `canClose` | `noClose` | |
There was a problem hiding this comment.
Note, MD tables have alignment feature 👀
Antreesy
approved these changes
Apr 14, 2025
|
The backport to # Switch to the target branch and update it
git checkout stable8
git pull origin stable8
# Create the new backport branch
git checkout -b backport/6719/stable8
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 7bd9eec4
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6719/stable8Error: Failed to check for changes with origin/stable8: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vue v9breaking changes #6384Replace
closeButtonContainedwithcloseButtonOutside.🏁 Checklist
stable8for maintained Vue 2 version.