Skip to content

docs(NcDateTimePicker): add prop documentation for all props #6727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 5, 2025

☑️ Resolves

  • no functional changes
  • document every prop we provide
  • add some developer docs on what some computed properties do
  • also resort the props in consistent order

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added 3. to review Waiting for reviews technical debt refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 5, 2025
@susnux susnux requested review from st3iny, ShGKme and Antreesy April 5, 2025 14:39
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 5, 2025
Also resort the props in consistent order.

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Maksim Sukharev <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/date-time-picker-props branch from fac29a7 to 20be0df Compare April 6, 2025 13:32
@susnux susnux merged commit bd8537b into main Apr 6, 2025
24 checks passed
@susnux susnux deleted the chore/date-time-picker-props branch April 6, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews refactor ♻️ Pull request that is neither a fix nor a feature technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants