Skip to content

feat(NcDateTimePicker): add time range picker and align naming #6728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

feat(NcDateTimePicker): add time range picker and align naming #6728

merged 1 commit into from
Apr 7, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 5, 2025 •
edited
Loading

☑️ Resolves

  1. Add a time range picker mode
  2. Align type names to TYPE(-range)?
  3. Fix some issues related to time mode (also without range)

🖼️ Screenshots

Screenshot 2025-04-05 at 18-05-34 Nextcloud Vue Style Guide

Screenshot 2025-04-05 at 18-05-43 Nextcloud Vue Style Guide

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added enhancement New feature or request 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component labels Apr 5, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 5, 2025
@susnux susnux requested review from st3iny, ShGKme and Antreesy April 5, 2025 16:09
@susnux susnux force-pushed the feat/time-picker branch from 5b4faa6 to e204bfa Compare April 5, 2025 16:12
@susnux susnux closed this Apr 5, 2025
@susnux susnux reopened this Apr 5, 2025
@susnux
Copy link
Contributor Author

susnux commented Apr 5, 2025

UI reloaded while clicking into the comment box -> closed by accident 😔
Needed to push a fix as I forgot to adjust the documentation of the type prop.

@susnux susnux force-pushed the feat/time-picker branch from e204bfa to f7c276a Compare April 6, 2025 13:42
@susnux
Copy link
Contributor Author

susnux commented Apr 6, 2025

Only rebased to resolve conflicts - no changes.

@st3iny
Copy link
Contributor

st3iny commented Apr 7, 2025

Can't wait to use this in Calendar 🤩

@susnux
feat(NcDateTimePicker): add time range picker and align naming
bfcb8de 
1. Add a time range picker mode
2. Align type names to `TYPE(-range)?`
3. Fix some issues related to time mode (also without range)

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the feat/time-picker branch from f7c276a to bfcb8de Compare April 7, 2025 18:47
@susnux susnux merged commit 5023ed3 into main Apr 7, 2025
24 checks passed
@susnux susnux deleted the feat/time-picker branch April 7, 2025 18:59
@susnux susnux mentioned this pull request Apr 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Antreesy approved these changes

@st3iny st3iny Awaiting requested review from st3iny

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request feature: datepicker Related to the date/time picker component
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @st3iny @ShGKme @Antreesy