Skip to content

Adjust all styles for RTL support and add directional prop to NcIconSvgWrapper #6733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

Adjust all styles for RTL support and add directional prop to NcIconSvgWrapper #6733

merged 2 commits into from
Apr 10, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 6, 2025 •
edited
Loading

☑️ Resolves

Adjusted all styles for RTL support and increased severity to error if there are new incompatible changes.

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added bug Something isn't working 3. to review Waiting for reviews RTL Right-to-Left languages support labels Apr 6, 2025
DorraJaouad
DorraJaouad reviewed Apr 6, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested yet

@susnux susnux requested a review from Antreesy April 8, 2025 08:55
@susnux
Copy link
Contributor Author

susnux commented Apr 8, 2025

/backport to stable8

@susnux susnux requested a review from DorraJaouad April 8, 2025 19:59
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 8, 2025
@susnux susnux changed the title fix: adjust all styles for RTL support Adjust all styles for RTL support and add directional prop to NcIconSvgWrapper Apr 9, 2025
@susnux susnux added enhancement New feature or request and removed bug Something isn't working labels Apr 9, 2025
DorraJaouad
DorraJaouad approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good, but I couldn't test on Talk for example as there is a conflict in deps when I try npm link :( and also the branch name seems to be problematic somehow.

Antreesy
Antreesy approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, but with applied styles via DevTools it seems to work.

@susnux susnux merged commit 7bcc558 into main Apr 10, 2025
28 checks passed
@susnux susnux deleted the fix/rtl branch April 10, 2025 14:41
@backportbot backportbot bot mentioned this pull request Apr 10, 2025
Merged
2 tasks
@susnux susnux mentioned this pull request Apr 16, 2025
Merged
4 tasks
@Antreesy Antreesy mentioned this pull request Apr 17, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Antreesy approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request RTL Right-to-Left languages support
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @ShGKme @DorraJaouad @Antreesy