Skip to content

refactor: adjust code to fix all SASS deprecations #6734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 16, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 6, 2025

☑️ Resolves

Most of the fixes resolve the deprecation of @import in SASS (due to conflict with native CSS @import).
Other fixes target the order of rules and styles, CSS attributes must be defined before any sub styles.

All reported issues are resolved (check output of npm run build before and after this PR).

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added 3. to review Waiting for reviews technical debt refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 6, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 6, 2025
@susnux susnux force-pushed the refactor/sass-deprecation branch from c09d9af to c1c8e6e Compare April 6, 2025 20:13
@susnux susnux requested a review from ShGKme April 6, 2025 20:39
@susnux susnux merged commit c012587 into main Apr 16, 2025
24 checks passed
@susnux susnux deleted the refactor/sass-deprecation branch April 16, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews refactor ♻️ Pull request that is neither a fix nor a feature technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants