Skip to content

chore: type check project on CI #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 16, 2025
Merged

chore: type check project on CI #6737

merged 4 commits into from
Apr 16, 2025

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 6, 2025

☑️ Resolves

  1. enforce project to be typescript compliant
  2. fix found issues
  • Missing type import in NcButton
  • Wrong types in NcDateTimePicker (less strict types only)
  • Missing event in NcDialog

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport bugfixes to stable8 for maintained Vue 2 version.

@susnux susnux added 3. to review Waiting for reviews technical debt refactor ♻️ Pull request that is neither a fix nor a feature labels Apr 6, 2025
@susnux susnux added this to the v9.0.0-rc.0 milestone Apr 6, 2025
Base automatically changed from chore/drop-cypress to main April 7, 2025 09:01
@susnux susnux marked this pull request as ready for review April 7, 2025 09:02
@susnux susnux requested review from ShGKme, Antreesy and skjnldsv April 7, 2025 09:02
ShGKme
ShGKme reviewed Apr 7, 2025
View reviewed changes
@susnux susnux requested a review from ShGKme April 7, 2025 09:51
ShGKme
ShGKme approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the current state. We can change the script name after the discussion anytime

@susnux susnux force-pushed the chore/type-check branch from d91614f to 411130d Compare April 16, 2025 08:11
st3iny
st3iny approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts:check 👍

@susnux susnux merged commit 7d8bcf6 into main Apr 16, 2025
29 checks passed
@susnux susnux deleted the chore/type-check branch April 16, 2025 08:33
@susnux susnux mentioned this pull request Apr 16, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews refactor ♻️ Pull request that is neither a fix nor a feature technical debt
Projects
None yet
Milestone
v9.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
5 participants
@susnux @st3iny @skjnldsv @ShGKme @Antreesy