feat(dialogs/spawnDialog): separate spawning options from dialog props and allow Element as a container

[ShGKme]

☑️ Resolves

• For: [RFC] Improve spawnDialog or add a new function #6731
• One more small improvement from a queue
• Do not mix dialog options and
• Coming next:
  • Fixing container usage
  • Return Promise
  • Typing

🏁 Checklist

• ⛑️ Tests are included or are not applicable
• 📘 Component documentation has been extended, updated or is not applicable
• 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

[susnux]

non breaking change as such I approve. But I would really favorite to move the onClose callback to a promise based return.

[Antreesy]

Looks valid.
But I don't get what's the reason for moving container out? it should be delegated to Vue on where to mount component instead of 'appendChild'?

[ShGKme]

But I don't get what's the reason for moving container out? it should be delegated to Vue on where to mount component instead of 'appendChild'?

Do you mean why we create a new element inside the container and not mount directly into the container?

[ShGKme]

If yes - because it allows using container for many dialogs and have other elements there.

For example, if you pass container: 'body', you probably expect that the dialog will be mounted somewhere at the end of the body. And you don't expect that entire body content will be replaced with the dialog only.

[susnux]

Suggested change

	if ('container' in props && typeof props.container === 'string') {
	if (!container && 'container' in props && typeof props.container === 'string') {

Do not override if already in opts

[ShGKme]

Did

if ('container' in props && typeof props.container === 'string') {
	container ??= props.container
}

instead.

(Seems slightly more readable to me to not think about brackets in !container && 'container' in props)

[ShGKme]

!container && 'container' in props vs !container && ('container' in props)

[susnux]

/backport to stable8