feat(dialogs/spawnDialog): return promise with the result #6758
Conversation
ShGKme
added
enhancement
src/functions/dialog/index.ts
Outdated
| element.remove() | ||
| const result = rest.map(v => toRaw(v)) | ||
| onClose?.(...result) | ||
| resolve(result.length > 1 ? result : result[0]) |
There was a problem hiding this comment.
So you have to emit array or object your self?
There was a problem hiding this comment.
In general, it's a common practice in Vue to always emit with one parameter in the payload. Then it's HTML-like and supports $event in template
There was a problem hiding this comment.
But here, if you emit many values - you get an array.
And if you emitted 1 value - you get it directly
There was a problem hiding this comment.
but you only resolve the first argument
There was a problem hiding this comment.
No, I only resolve the first argument when there are no arguments after the first
There was a problem hiding this comment.
@susnux It's me again.
What do you think about requiring to emit only one parameter? 👀
To keep description and typing simple.
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
feat/spawnDialogs--promise
branch
from
9e491b1 to
f6aa944
Compare
☑️ Resolves
spawnDialogor add a new function #6731onClosecallback, but also return a promise🏁 Checklist
stable8for maintained Vue 2 version or not applicable