refactor: drop string-length dependency and replace with native solution
#6779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ution Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
st3iny
approved these changes
Apr 15, 2025
| @@ -471,7 +474,8 @@ export default { | |||
| if (this.isEmptyValue || !this.maxlength) { | |||
| return false | |||
| } | |||
| return stringLength(this.localValue) > this.maxlength | |||
| const length = [...this.segmenter.segment(this.localValue)].length | |||
There was a problem hiding this comment.
Ahhh, I love JavaScript's horrific iterator abstraction ...
There was a problem hiding this comment.
I also would like if they returned an proper array like but on the otherside browser implementation could be probably faster with a generator like it is now.
There was a problem hiding this comment.
Yeah, it makes sense. I was referring to the incomplete API, for example, a <iterable>.count() function like in Rust etc. so that we don't have to copy memory all the time when working with iterators.
There was a problem hiding this comment.
PS: But it will get better very soon, now that an important proposal was merged.
skjnldsv
approved these changes
Apr 15, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Remove useless dependencies where we can just use native ES alternatives.
🏁 Checklist
stable8for maintained Vue 2 version or not applicable