fix(dialogs/spawnDialog): enhance spawnDialog types
#6781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mattersj <[email protected]>
Signed-off-by: mattersj <[email protected]>
Signed-off-by: mattersj <[email protected]>
…r `NoInfer` Signed-off-by: mattersj <[email protected]>
ShGKme
added
bug
This comment was marked as off-topic.
This comment was marked as off-topic.
ShGKme
approved these changes
Apr 15, 2025
src/functions/dialog/index.ts
Outdated
| import { createApp } from 'vue' | ||
| /* eslint-disable @typescript-eslint/no-explicit-any */ | ||
|
|
||
| import { createApp, type Component } from 'vue' |
There was a problem hiding this comment.
We prefer to always separate type and non-type imports (not included in the old eslint config, using in this repo).
Suggested change
| import { createApp, type Component } from 'vue' | |
| import type { Component } from 'vue' | |
| import { createApp } from 'vue' |
Comment on lines
+15
to
+17
| type DialogComponent<T extends Component> = 'onClose' extends keyof ComponentProps<T> | ||
| ? T | ||
| : 'Please provide a Dialog Component that supports `@close` event' |
There was a problem hiding this comment.
That's the best never I've ever seen
ShGKme
changed the title
spawnDialog typesspawnDialog types
Signed-off-by: mattersj <[email protected]>
mattersj
force-pushed
the
fix/spawnDialog--improvements
branch
from
2177ab4 to
b668872
Compare
4 tasks
Signed-off-by: mattersj <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
spawnDialogtypes:@closeevent can be passed tospawnDialog, otherwise an error is thrown on a type level suggesting what went wrong@closeevent's payloadThe implementation passes all the test cases from #6770 (comment)
🖼️ Screenshots
🚧 Tasks
🏁 Checklist
stable8for maintained Vue 2 version or not applicable