refactor(NcSavingIndicatorIcon): migrate component to vue #6823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
3. to review
|
/update-snapshots amend |
nextcloud-command
force-pushed
the
refactor/nc-saving-indicator-icon
branch
from
4fb12ce to
1a98114
Compare
juliusknorr
approved these changes
Apr 22, 2025
Signed-off-by: Ferdinand Thiessen <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
refactor/nc-saving-indicator-icon
branch
from
1a98114 to
f328b72
Compare
ShGKme
approved these changes
Apr 22, 2025
Comment on lines
+65
to
+68
| // ensure screenshots look consistent | ||
| test.beforeEach(({ page }) => { | ||
| page.addStyleTag({ content: '#app-content { padding: 12px; }\n' }) | ||
| }) |
There was a problem hiding this comment.
How does it change consistency (or consistency in what)?
There was a problem hiding this comment.
Consistent regardless of size due to border radius of app content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
stable8for maintained Vue 2 version or not applicable