Skip to content

fix(NcAvatar): do not load avatar from server, if iconClass was provided #6831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Apr 23, 2025

☑️ Resolves

  • Fix loading of faulty avatars (for non-users) from NcUserBubble

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Tasks

  • do we need explicit is-no-user prop at NcUserBubble for such cases?

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 2️⃣ Backport to stable8 for maintained Vue 2 version or not applicable

@Antreesy Antreesy added bug Something isn't working 3. to review Waiting for reviews feature: avatar Related to the avatar component labels Apr 23, 2025
@Antreesy Antreesy added this to the 9.0.0 milestone Apr 23, 2025
@Antreesy Antreesy requested review from susnux and ShGKme April 23, 2025 15:52
@Antreesy Antreesy self-assigned this Apr 23, 2025
@Antreesy Antreesy force-pushed the fix/noid/nc-avatar-with-icon-class branch from 81976f2 to 22f54cf Compare April 23, 2025 16:39
@Antreesy
Copy link
Contributor Author

/backport to stable8

@Antreesy Antreesy force-pushed the fix/noid/nc-avatar-with-icon-class branch from 22f54cf to 3f4daeb Compare April 24, 2025 08:06
@Antreesy Antreesy requested review from ShGKme and DorraJaouad April 24, 2025 08:06
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@Antreesy Antreesy merged commit 85cdcb1 into main Apr 24, 2025
29 checks passed
@Antreesy Antreesy deleted the fix/noid/nc-avatar-with-icon-class branch April 24, 2025 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working feature: avatar Related to the avatar component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants