-
Notifications
You must be signed in to change notification settings - Fork 93
fix(NcAppNavigationItem): multi level padding #6861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: greta <[email protected]>
/backport! to stable8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The level should be limited (or add scrolling), otherwise there is no place for deep nested items.
src/assets/NcAppNavigationItem.scss
Outdated
@@ -132,11 +132,12 @@ | |||
flex-direction: column; | |||
width: 100%; | |||
gap: var(--default-grid-baseline, 4px); | |||
padding-left: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the next line, it should be -inline-start
to support RTL
Signed-off-by: greta <[email protected]>
|
||
.app-navigation-entry { | ||
display: inline-flex; | ||
flex-wrap: wrap; | ||
padding-inline-start: $icon-size; | ||
padding-inline-start: 10px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i changed this to 10px, instead of 16px (icon-size), because the indentation is unnecessarily large.
I do not remember where but I think we had discussed this for files someday and designers mentioned a cap of 3rd level. |
Or 7th? |
Proposals for nesting limit:
.app-navigation-entry__children {
& & & & & & & {
--app-navigation-item-child-offset: 0;
}
}
const depth = inject('NcAppNavigationItem:depth', 0) + 1
provide('NcAppNavigationItem:depth', depth) |
Signed-off-by: greta <[email protected]>
☑️ Resolves
🖼️ Screenshots
🚧 Tasks
Check with them so they are aware this is fixed here.
🏁 Checklist
stable8
for maintained Vue 2 version or not applicable