Skip to content

fix(docs): NcContent with skip-actions crashes styleguidist #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 15, 2025

☑️ Resolves

  • Fix [next] Documention breaks when changing components #6922
  • Because #skip-actions was rendered by a Vue component in one of the examples, it had an unexpected crash on unmounted - there where no element to unmount
  • Solution - render #skip-actions on the document level, not inside a specific Vue component example

@ShGKme ShGKme requested review from susnux and kesselb May 15, 2025 17:05
@ShGKme ShGKme self-assigned this May 15, 2025
@ShGKme ShGKme added 3. to review Waiting for reviews Developer experience DX labels May 15, 2025
@ShGKme
Copy link
Contributor Author

ShGKme commented May 15, 2025

This PR also fixes the issue by not using NcContent in the docs:

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[next] Documention breaks when changing components
2 participants