fix(Places): Use event metadata to compute the place #2966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
|
/backport to stable31 |
|
/backport to stable30 |
artonge
force-pushed
the
artonge/fix/placemapper_with_s3
branch
2 times, most recently
from
951b8bf to
8f25ad2
Compare
artonge
force-pushed
the
artonge/chore/migrate_to_node_api
branch
from
25b10f2 to
9c4ada2
Compare
artonge
changed the base branch from
artonge/chore/migrate_to_node_api
to
master
When using S3 bucket, all the metadata will be computed in a background job. This means that the GPS info won't be in the DB yet, but it will be in the event's metadata. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/fix/placemapper_with_s3
branch
from
8f25ad2 to
71401b3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2966 +/- ##
=========================================
- Coverage 2.31% 2.28% -0.03%
=========================================
Files 98 97 -1
Lines 6190 6215 +25
Branches 112 111 -1
=========================================
- Hits 143 142 -1
- Misses 6047 6073 +26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
artonge
force-pushed
the
artonge/fix/placemapper_with_s3
branch
from
71401b3 to
a5951dc
Compare
ArtificialOwl
approved these changes
Apr 30, 2025
This was referenced Apr 30, 2025
backportbot
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using S3 bucket, all the metadata will be computed in a background job. This means that the GPS info won't be in the DB yet, but it will be in the event's metadata.