[stable30] fix(files_sharing): Fix error messages from password policy #49822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
come-nc
force-pushed
the
backport/49361/stable30
branch
from
8f58ae5 to
0c34df0
Compare
Exceptions thrown from password_policy may bubble up in share creation or update when a password is used. Their message is meant to be shown to the user. This always the case for HintException so we catch that instead of the subclass GenericShareException. Signed-off-by: Côme Chilliet <[email protected]>
…ric one Let the controller access the HintException and show the error to the user. Signed-off-by: Côme Chilliet <[email protected]>
This fixes a regression that bad password returned 403 instead of 400 because of previous changes. Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
backport/49361/stable30
branch
from
0c34df0 to
2546bc5
Compare
This was referenced Dec 12, 2024
|
/backport to stable29 |
|
/backport to stable28 |
|
Ready for review, both source branches are merged in master. |
come-nc
approved these changes
Dec 12, 2024
provokateurin
approved these changes
Dec 12, 2024
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: