Skip to content

fixing wildcard expansion in clusters bug #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

tom-brekke
Copy link

Following from #869

I used nf-core modules update vsearch/cluster to update the vsearch/cluster module
the update is a fix for the wildcard expansion that has been vetted by nf-core/modules and just needs integrating into ampliseq.

PR checklist

  • [ yes] This comment contains a description of changes (with reason).
  • [ n/a] If you've fixed a bug or added code that should be tested, add tests!
  • [ n/a] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • [ n/a] If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • [ yes] Make sure your code lints (nf-core pipelines lint).
  • [ yes] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [ yes] Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • [ n/a] Usage Documentation in docs/usage.md is updated.
  • [ n/a] Output Documentation in docs/output.md is updated.
  • [ no] CHANGELOG.md is updated.
  • [ no ] README.md is updated (including new tool citations and authors/contributors).

@d4straub
Copy link
Collaborator

Thanks!
It seems to me that you made the changes in the master branch though, that is not optimal. Optimal would be the dev branch, because the dev branch is the one with the most up to date code and the PR here has therefore weird history. Would you be willing to do it with the dev branch?
Apart from this I just have one other note: the CHANGELOG.md also should be updated with the change.

@tom-brekke tom-brekke closed this by deleting the head repository Apr 24, 2025
@tom-brekke
Copy link
Author

Sorry about that - sorting it now.
when I cloned the ampliseq repo I only grabbed the master branch. Had to delete my fork and re-clone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants