Skip to content

Merging template updates 2.3.1 #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 24, 2022
Merged

Merging template updates 2.3.1 #283

merged 19 commits into from
Mar 24, 2022

Conversation

d4straub
Copy link
Collaborator

@d4straub d4straub commented Mar 22, 2022 •
edited
Loading

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 22, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit 087885d

+| ✅ 144 tests passed       |+
#| ❔   1 tests were ignored |#

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.3.1
  • Run at 2022-03-24 11:20:32

@d4straub d4straub added this to the 2.2.0 milestone Mar 22, 2022
@d4straub d4straub changed the title Merging template updates 2.3 Merging template updates 2.3.1 Mar 23, 2022
jfy133
jfy133 approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little comment, but very likely would be worth updating wholesale when all the local modules are replaced with the nf-core 'offiical' ones

@d4straub
Copy link
Collaborator Author

I'll merge that and make a separate PR for 2.3.2!

@d4straub d4straub merged commit d0dbd17 into nf-core:dev Mar 24, 2022
@d4straub d4straub deleted the merging-template-updates-2.3 branch March 24, 2022 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@d4straub @jfy133 @nf-core-bot