Skip to content

Remove default: None from parameter schema #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2023
Merged

Remove default: None from parameter schema #447

merged 2 commits into from
May 19, 2023

Conversation

drpatelh
Copy link
Member

@drpatelh drpatelh commented May 19, 2023

Remove default entries specified as None in the parameter schema.

Latest release is failing in the community/showcase on Tower with the following error:
https://tower.nf/orgs/community/workspaces/showcase/watch/55hIP0xdXS2O0W

ERROR ~ No such file or directory: s3://nf-tower-bucket/scratch/55hIP0xdXS2O0W/None
 -- Check script '.nextflow/assets/nf-core/mag/./workflows/mag.nf' at line: 155 or see 'nf-55hIP0xdXS2O0W.log' file for more details
Saving cache: .nextflow/cache/64a85618-bd4a-4773-a875-f4a47a570a5d => s3://nf-tower-bucket/scratch/55hIP0xdXS2O0W/.nextflow/cache/64a85618-bd4a-4773-a875-f4a47a570a5d

Testing via the branch seems to bypass this. Pipeline is still running 🤞🏽
https://tower.nf/orgs/community/workspaces/showcase/watch/35RGI2TFVk34bb

@github-actions
Copy link

github-actions bot commented May 19, 2023

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a28be58

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-05-19 12:56:27

@maxulysse maxulysse merged commit ab3422b into dev May 19, 2023
@jfy133 jfy133 deleted the none_-bug branch July 7, 2023 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants