Skip to content

Fix Spades memory conversion issue #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 14, 2020
Merged

Fix Spades memory conversion issue #70

merged 5 commits into from
Jul 14, 2020

Conversation

maxibor
Copy link
Member

@maxibor maxibor commented Jul 13, 2020 •
edited
Loading

Fix to #61 with .toGiga()

PR checklist

  • This comment contains a description of changes (with reason)
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • CHANGELOG.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

@maxibor maxibor requested review from HadrienG and d4straub July 13, 2020 13:31
d4straub
d4straub approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly much cleaner code, great, thanks!

@maxibor maxibor linked an issue Jul 13, 2020 that may be closed by this pull request
SPAdes errors with >1000GB RAM #61
Closed
@skrakau skrakau merged commit 467b39f into nf-core:dev Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@HadrienG HadrienG Awaiting requested review from HadrienG

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SPAdes errors with >1000GB RAM
3 participants
@maxibor @d4straub @skrakau