Skip to content

Update CheckM2 #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 31, 2025
Merged

Update CheckM2 #774

merged 5 commits into from
Mar 31, 2025

Conversation

dialvarezs
Copy link
Contributor

@dialvarezs dialvarezs commented Mar 14, 2025

  • Update CheckM2 to v1.1.0
  • Update default CheckM2 database to the latest (v3).

Closes #773.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @dialvarezs !

Looks good only two comments:

  • docs/output.md needs updating
  • given the file name change, does anything downstream need to be updated to accommodate this (I'm thinking bin_summary.tsv)

@dialvarezs
Copy link
Contributor Author

I updated output, and no, nothing changes downstream, because the file is the same as before, only renamed.

@jfy133
Copy link
Member

jfy133 commented Mar 19, 2025

@amizeranschi is going to do a mega test of the branch (as he has a lot of interest in this as busco is underperforming on a huge dataset), and will report back - if he says he is happy with it we will merge in and do a patch release :)

@jfy133 jfy133 linked an issue Mar 21, 2025 that may be closed by this pull request
@amizeranschi
Copy link
Contributor

This code worked fine for me with 300+ large metagenomic samples. CheckM2 seems great, BTW. It might even be worth it to set it as default, instead of BUSCO.

@jfy133 jfy133 self-requested a review March 31, 2025 07:18
@jfy133 jfy133 merged commit 7d12e1c into nf-core:dev Mar 31, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CheckM2 modules to version 1.1.0
3 participants