-
Notifications
You must be signed in to change notification settings - Fork 125
Update CheckM2 #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CheckM2 #774
Conversation
44742bd
to
2b167dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @dialvarezs !
Looks good only two comments:
- docs/output.md needs updating
- given the file name change, does anything downstream need to be updated to accommodate this (I'm thinking bin_summary.tsv)
I updated output, and no, nothing changes downstream, because the file is the same as before, only renamed. |
@amizeranschi is going to do a mega test of the branch (as he has a lot of interest in this as busco is underperforming on a huge dataset), and will report back - if he says he is happy with it we will merge in and do a patch release :) |
This code worked fine for me with 300+ large metagenomic samples. CheckM2 seems great, BTW. It might even be worth it to set it as default, instead of BUSCO. |
Closes #773.
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).