Add DEFAULT_RENEW variable #896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
I just add test unit, could you please review ? |
|
Are there any estimates on if/when this could be merged? |
|
This would be really helpful, especially for in-house CAs with a even shorter forced refresh cycle than the default 60 days. acme-companion does currently not work with shorter CA policies, that issue certificates only for 30 days. @buchdag |
|
Something I could do to help move this along? |
|
@buchdag I have resolved conflict. Is there anything else preventing the merging of this PR? |
buchdag
reviewed
Mar 23, 2025
buchdag
reviewed
Mar 23, 2025
|
@buchdag I have made an update; please take a look. |
buchdag
approved these changes
Apr 3, 2025
|
@chinkung thank you ! 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to override day to renew the cert.
Certificate from some CA like Buypass has 180 days lifetime, so you might want to renew it at day 170 instead of day 60
See https://github.com/acmesh-official/acme.sh/wiki/BuyPass.com-CA