Skip to content

Fix config apply #480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 20, 2023
Merged

Fix config apply #480

merged 4 commits into from
Sep 20, 2023

Conversation

oliveromahony
Copy link
Contributor

@oliveromahony oliveromahony commented Sep 20, 2023 •
edited
Loading

Proposed changes

Fix config apply failure on main

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 1975952
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/650b1d24820f2a0007611bf2

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks dependencies labels Sep 20, 2023
@dhurley dhurley removed dependencies chore Pull requests for routine tasks labels Sep 20, 2023
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies labels Sep 20, 2023
@dhurley dhurley removed dependencies chore Pull requests for routine tasks labels Sep 20, 2023
@dhurley dhurley merged commit 97eda9a into main Sep 20, 2023
@dhurley dhurley deleted the fix-config-apply branch September 20, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@aphralG aphralG aphralG approved these changes

@craigell craigell Awaiting requested review from craigell

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliveromahony @dhurley @Dean-Coakley @aphralG