-
Notifications
You must be signed in to change notification settings - Fork 94
Use singleflight for caching environment.go calls #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for agent-public-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the title of the PR?
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
- Coverage 66.28% 66.12% -0.16%
==========================================
Files 118 118
Lines 13382 13411 +29
==========================================
- Hits 8870 8868 -2
- Misses 3921 3950 +29
- Partials 591 593 +2
☔ View full report in Codecov by Sentry. |
Proposed changes
Use singleflight for the some of the environment calls in environment.go. This should speed up performance.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTING
documentmake install-tools
and have attached any dependency changes to this pull requestREADME.md
)