Skip to content

Add CLI arg to set dynamic config path #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Add CLI arg to set dynamic config path #490

merged 16 commits into from
Oct 24, 2023

Conversation

Dean-Coakley
Copy link
Contributor

Proposed changes

Fixes: #337

  • Adds --dynamic-config-path cli arg which allows you to set a custom path to dynamic config file
  • Update docs
  • Simplify and extend config unit tests
  • Fix typos

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 7dec14c
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/65368a6448daf6000873d1b1

@github-actions github-actions bot added chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation labels Sep 28, 2023
@Dean-Coakley Dean-Coakley self-assigned this Sep 28, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (5d2118b) 66.25% compared to head (7dec14c) 66.26%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   66.25%   66.26%           
=======================================
  Files         118      118           
  Lines       13454    13457    +3     
=======================================
+ Hits         8914     8917    +3     
+ Misses       3945     3943    -2     
- Partials      595      597    +2     
Files Coverage Δ
src/core/config/types.go 0.00% <ø> (ø)
...or/github.com/nginx/agent/v2/src/plugins/events.go 84.17% <100.00%> (ø)
src/core/config/defaults.go 13.63% <50.00%> (+13.63%) ⬆️
src/core/config/config.go 70.34% <33.33%> (+1.07%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dean-Coakley Dean-Coakley merged commit 8f97855 into main Oct 24, 2023
@Dean-Coakley Dean-Coakley deleted the add-conf-dir-flag branch October 24, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks dependencies documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path to agent-dynamic.conf should be configurable
5 participants