Skip to content

Fix server example in sdk to have timeout #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Fix server example in sdk to have timeout #518

merged 3 commits into from
Nov 27, 2023

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Nov 20, 2023

Proposed changes

Change sdk server example to use http.Server so it has timeouts

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for agent-public-docs canceled.

Name Link
🔨 Latest commit 63bd01d
🔍 Latest deploy log https://app.netlify.com/sites/agent-public-docs/deploys/6564b1a5ce1e610008fbb82a

@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Nov 20, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89fc334) 66.14% compared to head (752ad65) 66.14%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #518   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files         118      118           
  Lines       13462    13462           
=======================================
  Hits         8905     8905           
  Misses       3957     3957           
  Partials      600      600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aphralG aphralG merged commit f7862b7 into main Nov 27, 2023
@aphralG aphralG deleted the fix-server-example branch November 27, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants